repo: Drop the branch parameter from ostree_repo_commit

It's unused. Make users explicitly write a ref if they want this;
high-level convenience API will be introduced later.

https://bugzilla.gnome.org/show_bug.cgi?id=707727

diff --git a/src/libostree/ostree-repo-commit.c b/src/libostree/ostree-repo-commit.c
index ca3a2dfc690729c448749b4637c3a03200f65150..a874af07594ebf6002046df6739fd891989f1e3a 100644 (file)
--- a/src/libostree/ostree-repo-commit.c
+++ b/src/libostree/ostree-repo-commit.c
@@ -1190,7 +1190,6 @@ create_empty_gvariant_dict (void)
 /**
  * ostree_repo_write_commit:
  * @self: Repo
- * @branch: Name of ref
  * @parent: (allow-none): ASCII SHA256 checksum for parent, or %NULL for none
  * @subject: Subject
  * @body: Body
@@ -1204,16 +1203,15 @@ create_empty_gvariant_dict (void)
  * and @root_metadata_checksum.
  */
 gboolean
-ostree_repo_write_commit (OstreeRepo *self,
-                          const char   *branch,
-                          const char   *parent,
-                          const char   *subject,
-                          const char   *body,
-                          const char   *root_contents_checksum,
-                          const char   *root_metadata_checksum,
-                          char        **out_commit,
-                          GCancellable *cancellable,
-                          GError      **error)
+ostree_repo_write_commit (OstreeRepo    *self,
+                          const char    *parent,
+                          const char    *subject,
+                          const char    *body,
+                          const char    *root_contents_checksum,
+                          const char    *root_metadata_checksum,
+                          char         **out_commit,
+                          GCancellable  *cancellable,
+                          GError       **error)
 {
   gboolean ret = FALSE;
   gs_free char *ret_commit = NULL;
@@ -1221,7 +1219,6 @@ ostree_repo_write_commit (OstreeRepo *self,
   gs_free guchar *commit_csum = NULL;
   GDateTime *now = NULL;
 
-  g_return_val_if_fail (branch != NULL, FALSE);
   g_return_val_if_fail (subject != NULL, FALSE);
   g_return_val_if_fail (root_contents_checksum != NULL, FALSE);
   g_return_val_if_fail (root_metadata_checksum != NULL, FALSE);

diff --git a/src/libostree/ostree-repo.h b/src/libostree/ostree-repo.h
index c02ec98e9e1a585717ed275f82dae6f995ac53c9..ab4c4c7997b9587dafe439a1a5b20080a47c864c 100644 (file)
--- a/src/libostree/ostree-repo.h
+++ b/src/libostree/ostree-repo.h
@@ -315,7 +315,6 @@ gboolean      ostree_repo_write_mtree (OstreeRepo         *self,
                                        GError            **error);
 
 gboolean      ostree_repo_write_commit (OstreeRepo   *self,
-                                        const char   *branch,
                                         const char   *parent,
                                         const char   *subject,
                                         const char   *body,

diff --git a/src/ostree/ot-builtin-commit.c b/src/ostree/ot-builtin-commit.c
index 329cd532ec5c6c24642d62442b19c65c8a7fb7ef..fd52a3e1c1ef368634e592c2662e2e7ad038e506 100644 (file)
--- a/src/ostree/ot-builtin-commit.c
+++ b/src/ostree/ot-builtin-commit.c
@@ -404,7 +404,7 @@ ostree_builtin_commit (int argc, char **argv, OstreeRepo *repo, GCancellable *ca
           goto out;
         }
 
-      if (!ostree_repo_write_commit (repo, opt_branch, parent, opt_subject, opt_body,
+      if (!ostree_repo_write_commit (repo, parent, opt_subject, opt_body,
                                      contents_checksum, root_metadata,
                                      &commit_checksum, cancellable, error))
         goto out;